Beatrice's Contributor App - Coder

SpaceDragon00 · May 28, 2021, 10:59pm

Byond Account: SpaceDragon00
Character Name(s): Beatrice Isamof(f), Beatrice Isekatt
Discord Name: Beatrice Isamof
Age: 20
How long have you played on Fulpstation?
267 hours since 12/24/20
Show us your work what is a PR/Piece of art/ Code you’ve done!

github.com/tgstation/tgstation

Nanotransen Legal Liability Initiative - Weapon Stats but more RP

tgstation:master ← SpaceDragon00:wepdescripts

opened 12:53AM - 03 May 21 UTC

SpaceDragon00

+218 -0

Also Known As: I made some changes to the initial PR to better comply with criti…cisms. I'm not exactly sure whether or not Im allowed to PR the changes to a request that was closed, since I couldn't find any examples on the contributing guide, but please feel free to close and let me know if I'm doing something shitty ## About The Pull Request Following a series of workplace ""Accidents,"" Nanotransen's team of legal experts have decided to outfit a number of HIGHLY DANGEROUS objects with holographic warning labels! Now if you try to claim that pesky workman's comp, you'll be held liable for daring to be near an object marked as a hazard - Gives an optional warning label hyperlink when you examine a dangerous item - Warning labels convey the primary offensive statistics of a given weapon in an esoteric manner (Damage, throw damage, armor pen, block chance and more) - No more raw damage numbers! (Now fully RP!) - Inspecting ammo gives you information on the projectile loaded inside (And none if you shot it!) - Inspecting ballistic weapons lets you know the caliber of the magazine (And none if you lost it!) - Inspecting energy weapons gives you their various modes ## Why It's Good For The Game I'll be a bit more thorough here to better explain why I think this is a good thing, as well as addressing some comments I got on the last PR Why I like it: One of the main frustrations I have that lead to the creation of this mechanic is the fact that it's difficult to nigh impossible to tell the basic weapon statistics of quite a few things without looking in the code. As far as I am aware there is no way to know some of the more esoteric weapons statistics (Armour pen, block chance) without looking in the code. This is, in my books, terrible for immersion as the base weapon statistics are very important for gameplay purposes, but looking at the code directly for this information is more game-ifying than anything Potential Questions: "What about the 'force' value on hover over?" That does not provide all of the information this provides. Yes this provides force, but it also provides caliber, throwing force, block chance, armor penetration, and bullet statistics "Isn't it kind of silly that you can make a weapon and a tag will automatically be applied?" Not anymore, with the power of holograms! Nanotransen nanny AIs will now automatically detect any dangerous object you happen to be looking at and apply the tag digitally for the sake of your safety! "Could you make this a function of another object like an analyzer, or part of a hud?" I _could_ but I feel that unnecessarily complicates the process of ascertaining important information. If there is a high enough demand for it, I could change it, or combine this PR and that [other one](https://github.com/tgstation/tgstation/pull/58858) "Won't this clog the examine text?" I guess, technically, but it's only one line since all the information is available through an optional hyperlink. I consider this to be at least as important as some other examine variables that take up a line or more "How do you hit someone .1 times?" When you're a hyper-advanced, borderline-parodical corporate hive mind in the far future, you find a way. "Why not just use whole numbers for the number of attacks?" So that miniscule changes in force (Like turning a laser scalpel 'on') can still be properly conveyed ## Changelog :cl: qol: Inspecting a weapon shows a warning label. By default, this shows force, throwforce, armour_penetration, and block_chance in an esoteric manner. Inspecting ammo gives information on the shot it produces, inspecting ballistic weapons lets you know their caliber, and inspecting energy weapons gives you their modes and the damage of those modes /:cl: ## Images ![image](https://user-images.githubusercontent.com/83368538/116833439-2c791700-ab87-11eb-92c6-df9d318e97d0.png) ![image](https://user-images.githubusercontent.com/83368538/116833444-2f740780-ab87-11eb-9007-154d4b85d9c6.png) ![image](https://user-images.githubusercontent.com/83368538/116833447-326ef800-ab87-11eb-891f-e846f9706ca3.png)

Mason · May 28, 2021, 11:33pm

Where’s the Fulp PRs

Helianthus · May 29, 2021, 12:29am

Since you attempted to pr the first one to fulp originally, I think that counts well enough. I’d be happy to have you as a part of our contributor team and look forward what you do next. +1

HazyAssaulter · May 29, 2021, 12:58am

I’ve asked them in the past why don’t they apply for mentor and they said because they were going to apply for contributor. +1 and por que no los dos?

JohnWillard · May 29, 2021, 1:57am

Obvious +1 from me, only sad thing is that this shitpost cant make sense anymore.

Delta · May 29, 2021, 11:34pm

got this message when examining a sword

Helianthus · May 30, 2021, 3:31am

Welcome to the contributor team! Your app has been accepted.